fix: Example pull_request_target: is wrong and very badly broken#23
Open
vorburger wants to merge 1 commit into
Open
fix: Example pull_request_target: is wrong and very badly broken#23vorburger wants to merge 1 commit into
vorburger wants to merge 1 commit into
Conversation
see www-learn-study/saraswati.learn.study#47 If you use pull_request_target: instead of pull_request: then the `actions/checkout`, at least in v4.1.1, will always check out the default branch, not the pull request.
Owner
|
Hi, I see that you're not checking out the repo as in the example: if you don't provide the ref I'm using in the example, Ref I'm using: pages-preview/dependents/source_repo.yml Line 42 in 3704427 Be careful with using these kinds of workflows with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see www-learn-study/saraswati.learn.study#47
If you use
pull_request_target:instead ofpull_request:then theactions/checkout, at least in its current v4.1.1, will always check out the default branch, not the pull request; see https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target